Added whitelistedMouseEvent option #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s whose execution wll not be stopped
|
This is a great addition 👌🏻 |
|
Why is this PR still open? I really need this in a project I'm working on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitelisted mouse events
This change introduces a new option, whitelistedMouseEvents, that lets users specify an optional list (array) of events whose execution will not be stopped.
The problem, that made this change necessary, was occurring in an ionic application, with snazzy info window template configured to not display the close button.
After opening the first snazzy-info-window it would remain open forever even when tapping on a different area of the map. This was because all the mouse/touch events were being stopped.
Now users can set the proper option (whitelistedMouseEvents) using an array of events, preventing all of them from being stopped.